Re: [PATCH 0/2] git diff -q option removal

2013-07-17 Thread Junio C Hamano
Stefan Beller stefanbel...@googlemail.com writes: The changes in the following patch are in diff_no_index.c, but the diff_no_index(...) is called from cmd_diff, which is in builtin/diff.c That cmd_diff is actually called from git.c having the { diff, cmd_diff }, entry in

Re: [PATCH 0/2] git diff -q option removal

2013-07-17 Thread Junio C Hamano
On Wed, Jul 17, 2013 at 10:04 AM, Junio C Hamano gits...@pobox.com wrote: If we wanted to make -q follow the spirit of its original addition to show-diff again, we could internally add a diff-filter when the -q option is parsed. Having said all that, I do not mean to advocate to retain -q.

Re: [PATCH 0/2] git diff -q option removal

2013-07-17 Thread Stefan Beller
On 07/17/2013 07:04 PM, Junio C Hamano wrote: Builtins link all sorts of stuff from outside, e.g. diff.c and diffcore-*.c at the toplevel. I do not see diff_no_index.c is any different, so I am probably not understanding your question. Thanks for the explanation. I am not yet very used to

[PATCH 0/2] git diff -q option removal

2013-07-16 Thread Stefan Beller
On 07/15/2013 12:07 AM, Jonathan Nieder wrote: This feature was obviously never tested with --no-index, so I agree it makes sense to remove it. Probably the commit message and a comment should say so, though. E.g.: diff --no-index: remove nonfunctional -q handling Before