Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-04 Thread Duy Nguyen
On Thu, Dec 3, 2015 at 9:53 PM, Max Kirillov wrote: > On Thu, Dec 03, 2015 at 09:07:07AM +0100, Duy Nguyen wrote: >> On Thu, Dec 3, 2015 at 7:15 AM, Max Kirillov wrote: >>> Using builtin defaults might be confusing for users - >>> editing the

Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-03 Thread Duy Nguyen
On Thu, Dec 3, 2015 at 7:15 AM, Max Kirillov wrote: > On Wed, Dec 02, 2015 at 08:13:41PM +0100, Nguyễn Thái Ngọc Duy wrote: >> Let's restart this. From the last discussion [1], we need to make >> core.worktree per-worktree for submodules to work. We also need >>

Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-03 Thread Junio C Hamano
Duy Nguyen writes: > If a variable _must_ be per-worktree or something will break, then it > should belong to the builtin list (so the user is less likely to mess > with it). If it may or may not be per-worktree, depending on one's > preference, then we can keep this in

Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-03 Thread Max Kirillov
On Thu, Dec 03, 2015 at 09:07:07AM +0100, Duy Nguyen wrote: > On Thu, Dec 3, 2015 at 7:15 AM, Max Kirillov wrote: >> Using builtin defaults might be confusing for users - >> editing the info/config.worktree they must keep in mind the >> list of defaults (which they seem to don't

Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-03 Thread Max Kirillov
On Thu, Dec 03, 2015 at 11:52:43AM -0800, Junio C Hamano wrote: > I actually prefer *not* to have any configurability > to avoid confusion between users. This could be an approach. But because of upgrade issues which I described in the other response it looks like this decision is not easy to

[PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-02 Thread Nguyễn Thái Ngọc Duy
Let's restart this. From the last discussion [1], we need to make core.worktree per-worktree for submodules to work. We also need core.sparseCheckout per-worktree. This series adds a pattern list, with .gitignore syntax mostly, that split config var set into two sets, the per-worktree set will be

Re: [PATCH 0/5] Split .git/config in multiple worktree setup

2015-12-02 Thread Max Kirillov
On Wed, Dec 02, 2015 at 08:13:41PM +0100, Nguyễn Thái Ngọc Duy wrote: > Let's restart this. From the last discussion [1], we need to make > core.worktree per-worktree for submodules to work. We also need > core.sparseCheckout per-worktree. Thank you. It would be nice to have it, so that features