Re: [PATCH 0/7] grep rev/path parsing fixes

2017-02-14 Thread Jonathan Tan
On 02/13/2017 10:00 PM, Jeff King wrote: I've fixed that, along with a few other bugs and cleanups. The complete series is below. Patch 2 is your (untouched) patch. My suggestions for your test are in patch 3, which can either remain on its own or be squashed in. [1/7]: grep: move thread

Re: [PATCH 0/7] grep rev/path parsing fixes

2017-02-13 Thread Jeff King
On Tue, Feb 14, 2017 at 01:00:21AM -0500, Jeff King wrote: > On Mon, Feb 13, 2017 at 08:20:37PM -0500, Jeff King wrote: > > > > If there is a repo and "foo" is a rev, the "--no-index or --untracked > > > cannot be used with revs." error would occur. If there is a repo and > > > "foo" is not a

[PATCH 0/7] grep rev/path parsing fixes

2017-02-13 Thread Jeff King
On Mon, Feb 13, 2017 at 08:20:37PM -0500, Jeff King wrote: > > If there is a repo and "foo" is a rev, the "--no-index or --untracked > > cannot be used with revs." error would occur. If there is a repo and > > "foo" is not a rev, this command would proceed as usual. If there is no > > repo, the