On 11 July 2017 at 00:42, Junio C Hamano wrote:
> Martin Ågren writes:
>> I am not moving all builtins to handling the pager on their own,
>> but instead introduce a flag IGNORE_PAGER_CONFIG and use it only
>> with the tag builtin. That means there's
Jeff King writes:
>> I see you CC'ed Peff who's passionate in this area, so these patches
>> are in good hands already ;-) I briefly skimmed your patches myself,
>> and did not spot anything glaringly wrong.
>
> Heh, I don't think of "paging tag output" as one of my passions, but
On Tue, Jul 11, 2017 at 03:50:39PM +0200, Martin Ågren wrote:
> > Would it makes sense to just have git-tag respect pager.tag in listing
> > mode, and otherwise ignore it completely?
>
> Yes. I doubt anyone would notice, and no-one should mind with the
> change (famous last words).
>
> It does
On 11 July 2017 at 12:19, Jeff King wrote:
> On Mon, Jul 10, 2017 at 11:55:13PM +0200, Martin Ågren wrote:
>
>> Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such
>> as "Vim: Warning: Output is not to a terminal" and a garbled terminal.
>> A user who makes use of
On Mon, Jul 10, 2017 at 03:42:14PM -0700, Junio C Hamano wrote:
> > A review would be much appreciated. Comments on the way I
> > structured the series would be just as welcome as ones on the
> > final result.
>
> I see you CC'ed Peff who's passionate in this area, so these patches
> are in good
On Mon, Jul 10, 2017 at 11:55:13PM +0200, Martin Ågren wrote:
> Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such
> as "Vim: Warning: Output is not to a terminal" and a garbled terminal.
> A user who makes use of `git tag -a` and `git tag -l` will probably
> choose not to
Martin Ågren writes:
> Using, e.g., `git -c pager.tag tag -a new-tag` results in errors
> such as "Vim: Warning: Output is not to a terminal" and a garbled
> terminal. A user who makes use of `git tag -a` and `git tag -l`
> will probably choose not to configure
Using, e.g., `git -c pager.tag tag -a new-tag` results in errors such as "Vim:
Warning: Output is not to a terminal" and a garbled terminal. A user who makes
use of `git tag -a` and `git tag -l` will probably choose not to configure
`pager.tag` or to set it to "no", so that `git tag -a` will
8 matches
Mail list logo