Re: [PATCH 01/10] submodule: decouple url and submodule existence

2017-03-06 Thread Brandon Williams
On 03/01, Stefan Beller wrote: Sorry I've been slow at rerolling this. I'll send out a reroll today. > IIRC most of the series is actually refactoring, i.e. > providing a central function that answers > "is this submodule active/initialized?" and then making use of this > function. > > Maybe

Re: [PATCH 01/10] submodule: decouple url and submodule existence

2017-03-01 Thread Junio C Hamano
Brandon Williams writes: > On 02/24, Junio C Hamano wrote: > >> Also as a grouping measure, submodule.active that lists submodule >> paths feels hard to use. When switching between two branches in the >> superproject that have the same submodule bound at two different >>

Re: [PATCH 01/10] submodule: decouple url and submodule existence

2017-03-01 Thread Stefan Beller
IIRC most of the series is actually refactoring, i.e. providing a central function that answers "is this submodule active/initialized?" and then making use of this function. Maybe it would be easier to reroll these refactorings first without adding in the change of behavior. Off the list we

Re: [PATCH 01/10] submodule: decouple url and submodule existence

2017-03-01 Thread Brandon Williams
On 02/24, Junio C Hamano wrote: > Brandon Williams writes: > > > Currently the submodule..url config option is used to determine > > if a given submodule exists and is interesting to the user. This > > however doesn't work very well because the URL is a config option for > >

Re: [PATCH 01/10] submodule: decouple url and submodule existence

2017-02-24 Thread Junio C Hamano
Brandon Williams writes: > Currently the submodule..url config option is used to determine > if a given submodule exists and is interesting to the user. This > however doesn't work very well because the URL is a config option for > the scope of a repository, whereas the

[PATCH 01/10] submodule: decouple url and submodule existence

2017-02-23 Thread Brandon Williams
Currently the submodule..url config option is used to determine if a given submodule exists and is interesting to the user. This however doesn't work very well because the URL is a config option for the scope of a repository, whereas the existence of a submodule is an option scoped to the working