Re: [PATCH 1/1] git-p4: add format-patch subcommand

On 26 February 2018 at 23:48, Eric Sunshine wrote: > On Mon, Feb 26, 2018 at 6:48 AM, Luke Diamand wrote: >> It takes a list of P4 changelists and generates a patch for >> each one, using "p4 describe". >> [...] Just to say that I almost got this

Re: [PATCH 1/1] git-p4: add format-patch subcommand

On Mon, Feb 26, 2018 at 6:48 AM, Luke Diamand wrote: > It takes a list of P4 changelists and generates a patch for > each one, using "p4 describe". > [...] > Signed-off-by: Luke Diamand > --- > diff --git a/git-p4.py b/git-p4.py > @@ -3749,6 +3761,277 @@ class

Re: [PATCH 1/1] git-p4: add format-patch subcommand

very nice subcommand, I tested it with a shelved CL and a submitted CL. Find my comments inline On Mon, Feb 26, 2018 at 12:48 PM, Luke Diamand wrote: > It takes a list of P4 changelists and generates a patch for > each one, using "p4 describe". > > This is especially useful for

[PATCH 1/1] git-p4: add format-patch subcommand

It takes a list of P4 changelists and generates a patch for each one, using "p4 describe". This is especially useful for applying shelved changelists to your git-p4 tree; the existing "git p4" subcommands do not handle these. That's because they "p4 print" the contents of each file at a given