Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR

2015-05-26 Thread Junio C Hamano
Luke Diamand l...@diamand.org writes: On 07/05/15 23:16, Junio C Hamano wrote: Luke Diamand l...@diamand.org writes: [Resurrecting old thread] ... To me, that seems to imply that for GIT_WINDOWS_NATIVE, we take the *second* branch and use sh, so again, the the code as it stands will be

Re: [PATCH 2/2] git-p4: fix handling of multi-word P4EDITOR

2015-05-24 Thread Luke Diamand
On 07/05/15 23:16, Junio C Hamano wrote: Luke Diamand l...@diamand.org writes: [Resurrecting old thread] Looking at run-command.c, GIT_WINDOES_NATIVE and POSIX seems to use pretty much the same construct, except that they use SHELL_PATH instead of sh. I think the state of git on Windows