Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

Hi Daniel, On Fri, 5 May 2017, Daniel Ferreira (theiostream) wrote: > On Fri, May 5, 2017 at 7:30 PM, Johannes Schindelin > wrote: > >> +static int git_add_interactive_config(const char *var, > > > > Not git_add_interactive__helper_config()? ;-) > > I don't get if

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

Hi, On Sat, 6 May 2017, Ævar Arnfjörð Bjarmason wrote: > On Sat, May 6, 2017 at 12:30 AM, Johannes Schindelin > wrote: > > Hi Daniel, > > > > > > On Fri, 5 May 2017, Daniel Ferreira wrote: > >> +static void print_modified(void) > >> +{ > >> + int i; > >> +

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Sat, May 6, 2017 at 1:13 AM, Daniel Ferreira (theiostream) wrote: > On Fri, May 5, 2017 at 7:30 PM, Johannes Schindelin > wrote: >>> +static int git_add_interactive_config(const char *var, >> >> Not git_add_interactive__helper_config()? ;-) > > I

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Fri, May 5, 2017 at 7:30 PM, Johannes Schindelin wrote: >> +static int git_add_interactive_config(const char *var, > > Not git_add_interactive__helper_config()? ;-) I don't get if you mean this ironically (because of the verbosity) or if you do think this would be

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Sat, May 6, 2017 at 12:30 AM, Johannes Schindelin wrote: > Hi Daniel, > > > On Fri, 5 May 2017, Daniel Ferreira wrote: >> +static void print_modified(void) >> +{ >> + int i; >> + struct add_interactive_status s; >> + const char *modified_fmt = _("%12s

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

Hi Daniel, On Fri, 5 May 2017, Daniel Ferreira wrote: > Create a builtin helper for git-add--interactive, which right now is > only able to reproduce git-add--interactive.perl's status_cmd() > function, providing a summarized diff numstat to the user. > > This is the first step in an effort to

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Fri, May 5, 2017 at 11:21 PM, Johannes Schindelin wrote: > Hi, > > On Fri, 5 May 2017, Ævar Arnfjörð Bjarmason wrote: > >> int cmd_add_interactive__helper(int argc, const char **argv, const char >> *prefix) >> { >> - int i, found_opt = 0; >> - >> -

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

Hi, On Fri, 5 May 2017, Ævar Arnfjörð Bjarmason wrote: > int cmd_add_interactive__helper(int argc, const char **argv, const char > *prefix) > { > - int i, found_opt = 0; > - > - git_config(git_add_interactive_config, NULL); > + int opt_status = 0; > > - for (i = 1; i < argc;

Re: [PATCH 2/3] add--interactive: add builtin helper for interactive add

On Fri, May 5, 2017 at 8:43 PM, Daniel Ferreira wrote: > Create a builtin helper for git-add--interactive, which right now is > only able to reproduce git-add--interactive.perl's status_cmd() > function, providing a summarized diff numstat to the user. I'm not a user of add -i

[PATCH 2/3] add--interactive: add builtin helper for interactive add

Create a builtin helper for git-add--interactive, which right now is only able to reproduce git-add--interactive.perl's status_cmd() function, providing a summarized diff numstat to the user. This is the first step in an effort to convert git-add--interactive.perl to a C builtin, in search for