[PATCH 2/6] remote.c: drop remote pointer from struct branch

2015-03-31 Thread Jeff King
When we create each branch struct, we fill in the remote_name field from the config, and then fill in the actual remote field based on that name. However, it turns out that nobody really cares about this field. The only two sites that access it are: 1. git-merge, which uses it to notice when

Re: [PATCH 2/6] remote.c: drop remote pointer from struct branch

2015-03-31 Thread Jeff King
On Tue, Mar 31, 2015 at 01:50:05PM -0700, Junio C Hamano wrote: Getting rid of it drops one potential source of confusion: is the value the match for remote_name, or is it the remote we would fetch from when on that branch (i.e., does it fall back to origin)? I had to read the above

Re: [PATCH 2/6] remote.c: drop remote pointer from struct branch

2015-03-31 Thread Junio C Hamano
Jeff King p...@peff.net writes: When we create each branch struct, we fill in the remote_name field from the config, and then fill in the actual remote field based on that name. However, it turns out that nobody really cares about this field. The only two sites that access it are: 1.

Re: [PATCH 2/6] remote.c: drop remote pointer from struct branch

2015-03-31 Thread Junio C Hamano
Jeff King p...@peff.net writes: On Tue, Mar 31, 2015 at 01:50:05PM -0700, Junio C Hamano wrote: it first looked somewhat unnatural that you kept the name with which you need to trigger a search for the structure, instead of keeping the structure, one of whose field is its name already. ...