Re: [PATCH 3/3] ref-filter: free item->value and item->value->s

2018-10-12 Thread Jeff King
On Thu, Oct 11, 2018 at 10:19:22AM +0900, Junio C Hamano wrote: > > @@ -1373,36 +1379,31 @@ static void fill_remote_ref_details(struct > > used_atom *atom, const char *refname, > > } > > } else if (atom->u.remote_ref.option == RR_TRACKSHORT) { > > if

Re: [PATCH 3/3] ref-filter: free item->value and item->value->s

2018-10-10 Thread Junio C Hamano
Olga Telezhnaya writes: > Release item->value. > Initialize item->value->s dynamically and then release its resources. > Release some local variables. Again, "why" is lacking. > @@ -1373,36 +1379,31 @@ static void fill_remote_ref_details(struct used_atom > *atom, const char *refname, >

[PATCH 3/3] ref-filter: free item->value and item->value->s

2018-10-09 Thread Olga Telezhnaya
Release item->value. Initialize item->value->s dynamically and then release its resources. Release some local variables. Signed-off-by: Olga Telezhnaia --- ref-filter.c | 95 +--- 1 file changed, 53 insertions(+), 42 deletions(-) diff --git