Re: [PATCH 3/6] unpack-trees: don't shadow global var the_index

2018-06-05 Thread Ramsay Jones
On 05/06/18 16:43, Nguyễn Thái Ngọc Duy wrote: > This function mark_new_skip_worktree() has an argument named the_index > which is also the name of a global variable. While they have different > types (the global the_index is not a pointer) mistakes can easily > happen and it's also confusing

[PATCH 3/6] unpack-trees: don't shadow global var the_index

2018-06-05 Thread Nguyễn Thái Ngọc Duy
This function mark_new_skip_worktree() has an argument named the_index which is also the name of a global variable. While they have different types (the global the_index is not a pointer) mistakes can easily happen and it's also confusing for readers. Rename the function argument to something