[PATCH 4/6] fsck: check tag objects' headers

2014-08-28 Thread Johannes Schindelin
We inspect commit objects pretty much in detail in git-fsck, but we just glanced over the tag objects. Let's be stricter. This work was sponsored by GitHub Inc. Signed-off-by: Johannes Schindelin johannes.schinde...@gmx.de --- fsck.c | 88

Re: [PATCH 4/6] fsck: check tag objects' headers

2014-08-28 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: We inspect commit objects pretty much in detail in git-fsck, but we just glanced over the tag objects. Let's be stricter. This work was sponsored by GitHub Inc. Is it only this commit, or all of these patches in the series? Does GitHub

Re: [PATCH 4/6] fsck: check tag objects' headers

2014-08-28 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: +if (check_refname_format(buffer, REFNAME_ALLOW_ONELEVEL)) +ret = error_func(tag-object, FSCK_ERROR, invalid 'tag' name: %s, buffer); +*eol = '\n'; I actually think this check is harmful. Let me take this one back; we do a moral