Re: [PATCH 5/8] revision.c: better error reporting on ref from different worktrees

2018-09-23 Thread Duy Nguyen
On Sun, Sep 23, 2018 at 10:25 AM Eric Sunshine wrote: > > @@ -487,6 +487,28 @@ int submodule_uses_worktrees(const char *path) > > +void strbuf_worktree_ref(const struct worktree *wt, > > +struct strbuf *sb, > > +const char *refname) > > +{ > > +

Re: [PATCH 5/8] revision.c: better error reporting on ref from different worktrees

2018-09-23 Thread Eric Sunshine
On Sat, Sep 22, 2018 at 2:05 PM Nguyễn Thái Ngọc Duy wrote: > Make use of the new ref aliases to pass refs from another worktree > around and access them from the current ref store instead. This does > not change any functionality, but when a problem shows up, we would > report something like

[PATCH 5/8] revision.c: better error reporting on ref from different worktrees

2018-09-22 Thread Nguyễn Thái Ngọc Duy
Make use of the new ref aliases to pass refs from another worktree around and access them from the current ref store instead. This does not change any functionality, but when a problem shows up, we would report something like fatal: bad object worktrees/ztemp/HEAD warning: reflog of