[PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree

2018-08-13 Thread Stefan Beller
e98317508c0 (submodule: ensure core.worktree is set after update, 2018-06-18) was overly aggressive in calling connect_work_tree_and_git_dir as that ensures both the 'core.worktree' configuration is set as well as setting up correct gitlink file pointing at the git directory. We do not need to

Re: [PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree

2018-08-10 Thread Brandon Williams
On 08/10, Stefan Beller wrote: > > > + cfg_file = xstrfmt("%s/config", subrepo.gitdir); > > > > As I mentioned here: > > https://public-inbox.org/git/20180807230637.247200-1-bmw...@google.com/T/#t > > > > This lines should probably be more like: > > > > cfg_file = repo_git_path(,

Re: [PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree

2018-08-10 Thread Stefan Beller
> > + cfg_file = xstrfmt("%s/config", subrepo.gitdir); > > As I mentioned here: > https://public-inbox.org/git/20180807230637.247200-1-bmw...@google.com/T/#t > > This lines should probably be more like: > > cfg_file = repo_git_path(, "config"); > Why? You did not mention the

Re: [PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree

2018-08-10 Thread Brandon Williams
On 08/03, Stefan Beller wrote: > e98317508c0 (submodule: ensure core.worktree is set after update, > 2018-06-18) was overly aggressive in calling connect_work_tree_and_git_dir > as that ensures both the 'core.worktree' configuration is set as well as > setting up correct gitlink file pointing at

[PATCH 6/7] submodule--helper: replace connect-gitdir-workingtree by ensure-core-worktree

2018-08-03 Thread Stefan Beller
e98317508c0 (submodule: ensure core.worktree is set after update, 2018-06-18) was overly aggressive in calling connect_work_tree_and_git_dir as that ensures both the 'core.worktree' configuration is set as well as setting up correct gitlink file pointing at the git directory. We do not need to