Re: [PATCH 6/9] am: move advice.amWorkDir parsing back to advice.c

2018-05-11 Thread Eric Sunshine
On Thu, May 10, 2018 at 10:19 AM Nguyễn Thái Ngọc Duy wrote: > The only benefit from this move (apart from cleaner code) is that > advice.amWorkDir should now show up in `git help --config`. There > should be no regression since advice config is always read by the >

[PATCH 6/9] am: move advice.amWorkDir parsing back to advice.c

2018-05-10 Thread Nguyễn Thái Ngọc Duy
The only benefit from this move (apart from cleaner code) is that advice.amWorkDir should now show up in `git help --config`. There should be no regression since advice config is always read by the git_default_config(). While at there, use advise() like other code. We now get "hint: " prefix and