Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-28 Thread Lars Schneider
On 26 Oct 2015, at 21:40, Luke Diamand wrote: > On 24/10/15 19:08, Lars Schneider wrote: >> >> On 21 Oct 2015, at 08:32, Luke Diamand wrote: >> >>> On 19/10/15 19:43, larsxschnei...@gmail.com wrote: From: Lars Schneider

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-26 Thread Luke Diamand
On 24/10/15 19:08, Lars Schneider wrote: On 21 Oct 2015, at 08:32, Luke Diamand wrote: On 19/10/15 19:43, larsxschnei...@gmail.com wrote: From: Lars Schneider This seems to be adding a new function in the middle of an existing function. Is

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-24 Thread Lars Schneider
On 20 Oct 2015, at 19:27, Junio C Hamano wrote: > larsxschnei...@gmail.com writes: > >> diff --git a/git-p4.py b/git-p4.py >> index 0093fa3..6c50c74 100755 >> --- a/git-p4.py >> +++ b/git-p4.py >> @@ -2288,12 +2288,6 @@ class P4Sync(Command, P4UserMap): >>

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-24 Thread Lars Schneider
On 21 Oct 2015, at 08:32, Luke Diamand wrote: > On 19/10/15 19:43, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> A changelist that contains only excluded files (e.g. via client spec or >> branch prefix) will be imported as empty

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-24 Thread Luke Diamand
On 24/10/15 17:28, Lars Schneider wrote: Also I have this suspicion that those who do want to use client spec to get a narrowed view into the history would almost always want this "ignore empty" behaviour (I'd even say the current behaviour to leave empty commits by default is a bug). What

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-21 Thread Luke Diamand
On 19/10/15 19:43, larsxschnei...@gmail.com wrote: From: Lars Schneider A changelist that contains only excluded files (e.g. via client spec or branch prefix) will be imported as empty commit. Add option "git-p4.ignoreEmptyCommits" to ignore these commits.

Re: [PATCH v1] git-p4: Add option to ignore empty commits

2015-10-20 Thread Junio C Hamano
larsxschnei...@gmail.com writes: > diff --git a/git-p4.py b/git-p4.py > index 0093fa3..6c50c74 100755 > --- a/git-p4.py > +++ b/git-p4.py > @@ -2288,12 +2288,6 @@ class P4Sync(Command, P4UserMap): > filesToDelete = [] > > for f in files: > -# if using a client

[PATCH v1] git-p4: Add option to ignore empty commits

2015-10-19 Thread larsxschneider
From: Lars Schneider A changelist that contains only excluded files (e.g. via client spec or branch prefix) will be imported as empty commit. Add option "git-p4.ignoreEmptyCommits" to ignore these commits. Signed-off-by: Lars Schneider ---