Re: [PATCH v10 08/21] stash: convert apply to builtin

2018-10-15 Thread Thomas Gummerer
On 10/15, Johannes Schindelin wrote: > Hi Paul, > > On Mon, 15 Oct 2018, Paul-Sebastian Ungureanu wrote: > > > +static void assert_stash_like(struct stash_info *info, const char > > *revision) > > +{ > > + if (get_oidf(>b_commit, "%s^1", revision) || > > + get_oidf(>w_tree, "%s:",

Re: [PATCH v10 08/21] stash: convert apply to builtin

2018-10-15 Thread Johannes Schindelin
Hi Paul, On Mon, 15 Oct 2018, Paul-Sebastian Ungureanu wrote: > +static void assert_stash_like(struct stash_info *info, const char *revision) > +{ > + if (get_oidf(>b_commit, "%s^1", revision) || > + get_oidf(>w_tree, "%s:", revision) || > + get_oidf(>b_tree, "%s^1:",

[PATCH v10 08/21] stash: convert apply to builtin

2018-10-14 Thread Paul-Sebastian Ungureanu
From: Joel Teichroeb Add a builtin helper for performing stash commands. Converting all at once proved hard to review, so starting with just apply lets conversion get started without the other commands being finished. The helper is being implemented as a drop in replacement for stash so that