Re: [PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-29 Thread Johannes Schindelin
Hi Junio, On Thu, 29 Nov 2018, Johannes Schindelin wrote: > On Mon, 26 Nov 2018, Junio C Hamano wrote: > > > Junio C Hamano writes: > > > > > Thomas Gummerer writes: > > > > > >> Thanks for your work on this! I have read through the range-diff and > > >> the new patch of this last round,

Re: [PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-29 Thread Johannes Schindelin
Hi Junio, On Mon, 26 Nov 2018, Junio C Hamano wrote: > Junio C Hamano writes: > > > Thomas Gummerer writes: > > > >> Thanks for your work on this! I have read through the range-diff and > >> the new patch of this last round, and this addresses all the comments > >> I had on v10 (and some

Re: [PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-25 Thread Junio C Hamano
Junio C Hamano writes: > Thomas Gummerer writes: > >> Thanks for your work on this! I have read through the range-diff and >> the new patch of this last round, and this addresses all the comments >> I had on v10 (and some more :)). I consider it >> Reviewed-by: Thomas Gummerer > > Thanks. >

Re: [PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-25 Thread Junio C Hamano
Thomas Gummerer writes: > Thanks for your work on this! I have read through the range-diff and > the new patch of this last round, and this addresses all the comments > I had on v10 (and some more :)). I consider it > Reviewed-by: Thomas Gummerer Thanks. One thing that bothers me is that

Re: [PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-25 Thread Thomas Gummerer
On 11/23, Paul-Sebastian Ungureanu wrote: > Hello, > > This is the 11th iteration of C git stash. Here are some of the changes, > based on Thomas's and dscho's suggestions (from mailing list / pull request > #495): Thanks for your work on this! I have read through the range-diff and the new

[PATCH v11 00/22] Convert "git stash" to C builtin

2018-11-22 Thread Paul-Sebastian Ungureanu
Hello, This is the 11th iteration of C git stash. Here are some of the changes, based on Thomas's and dscho's suggestions (from mailing list / pull request #495): - improved memory management. Now, the callers of `do_create_stash()` are responsible of freeing the parameter they pass in.