Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

> On 05 Apr 2018, at 18:41, Torsten Bögershausen wrote: > > On 01.04.18 15:24, Lars Schneider wrote: >>> TRUE or false are values, but just wrong ones. >>> If this test is removed, the user will see "failed to encode "TRUE" to >>> "UTF-8", >>> which should give enough

Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

On 01.04.18 15:24, Lars Schneider wrote: >> TRUE or false are values, but just wrong ones. >> If this test is removed, the user will see "failed to encode "TRUE" to >> "UTF-8", >> which should give enough information to fix it. > > I see your point. However, I would like to stop the processing

Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

> On 18 Mar 2018, at 08:24, Torsten Bögershausen wrote: > > Some comments inline > > On Fri, Mar 09, 2018 at 06:35:32PM +0100, lars.schnei...@autodesk.com wrote: >> From: Lars Schneider >> >> Git recognizes files encoded with ASCII or one of its

Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

Some comments inline On Fri, Mar 09, 2018 at 06:35:32PM +0100, lars.schnei...@autodesk.com wrote: > From: Lars Schneider > > Git recognizes files encoded with ASCII or one of its supersets (e.g. > UTF-8 or ISO-8859-1) as text files. All other encodings are usually >

Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

> On 09 Mar 2018, at 20:10, Junio C Hamano wrote: > > lars.schnei...@autodesk.com writes: > >> +static const char *default_encoding = "UTF-8"; >> + >> ... >> +static const char *git_path_check_encoding(struct attr_check_item *check) >> +{ >> +const char *value =

Re: [PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

lars.schnei...@autodesk.com writes: > +static const char *default_encoding = "UTF-8"; > + > ... > +static const char *git_path_check_encoding(struct attr_check_item *check) > +{ > + const char *value = check->value; > + > + if (ATTR_UNSET(value) || !strlen(value)) > + return

[PATCH v11 06/10] convert: add 'working-tree-encoding' attribute

From: Lars Schneider Git recognizes files encoded with ASCII or one of its supersets (e.g. UTF-8 or ISO-8859-1) as text files. All other encodings are usually interpreted as binary and consequently built-in Git text processing tools (e.g. 'git diff') as well as most Git