Re: [PATCH v16 0/7] config commit verbose

2016-05-09 Thread Junio C Hamano
Jeff King writes: > I guess I do not really consider the template content to be the primary > thing the command is doing. It is subjective, though. I don't feel > strongly enough to keep discussing it if other people don't agree. I just see the primary thing of what "commit -e"

Re: [PATCH v16 0/7] config commit verbose

2016-05-09 Thread Jeff King
On Sun, May 08, 2016 at 11:48:31AM -0700, Junio C Hamano wrote: > Ævar Arnfjörð Bjarmason writes: > > > I.e. I really expect --verbose to be a more verbose version of the > > primary thing a command is doing, which in the case of "commit > > --amend" is giving me info I need

Re: [PATCH v16 0/7] config commit verbose

2016-05-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I.e. I really expect --verbose to be a more verbose version of the > primary thing a command is doing, which in the case of "commit > --amend" is giving me info I need to modify the commit. That summarises what I wanted to say very well.

Re: [PATCH v16 0/7] config commit verbose

2016-05-07 Thread Ævar Arnfjörð Bjarmason
On Sat, May 7, 2016 at 7:32 AM, Jeff King wrote: > On Fri, May 06, 2016 at 08:33:15AM -0700, Junio C Hamano wrote: > >> > Then I replied: >> > >> >However, that doesn't mean that we have to spread this badly chosen >> >name from options to config variables, does it? I

Re: [PATCH v16 0/7] config commit verbose

2016-05-06 Thread Jeff King
On Fri, May 06, 2016 at 08:33:15AM -0700, Junio C Hamano wrote: > > Then I replied: > > > >However, that doesn't mean that we have to spread this badly chosen > >name from options to config variables, does it? I think that if we > >are going to define a new config variable today,

Re: [PATCH v16 0/7] config commit verbose

2016-05-06 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > On Fri, May 6, 2016 at 6:16 PM, Pranit Bauva wrote: >> [+cc:git@vger.kernel.org] Because its an interesting fact to be shared >> which isn't covered elsewhere. >> >> On Fri, May 6, 2016 at 2:53 AM, Ævar Arnfjörð

Re: [PATCH v16 0/7] config commit verbose

2016-05-06 Thread Ævar Arnfjörð Bjarmason
On Fri, May 6, 2016 at 6:16 PM, Pranit Bauva wrote: > [+cc:git@vger.kernel.org] Because its an interesting fact to be shared > which isn't covered elsewhere. > > On Fri, May 6, 2016 at 2:53 AM, Ævar Arnfjörð Bjarmason > wrote: >> Sending this privately

Re: [PATCH v16 0/7] config commit verbose

2016-05-06 Thread Pranit Bauva
[+cc:git@vger.kernel.org] Because its an interesting fact to be shared which isn't covered elsewhere. On Fri, May 6, 2016 at 2:53 AM, Ævar Arnfjörð Bjarmason wrote: > Sending this privately since it's probably covered elsewhere. With > this, if I set the option will "reword" in

Re: [PATCH v16 0/7] config commit verbose

2016-05-06 Thread Junio C Hamano
SZEDER Gábor writes: > A while ago in a related thread Peff remarked about 'git commit's > '--quiet' and '--verbose' options: > >I think that is a UX mistake, and we would not do >it that way if designing from scratch. But we're stuck with it for >historical

Re: [PATCH v16 0/7] config commit verbose

2016-05-05 Thread Eric Sunshine
On Thu, May 5, 2016 at 3:21 PM, Junio C Hamano wrote: > Pranit Bauva writes: >> This series of patches add a configuration variable for verbose in >> git-commit. >> >> Changes wrt v15: >> * Remove the previous patch 7/7 and split the tests. Include one

Re: [PATCH v16 0/7] config commit verbose

2016-05-05 Thread Junio C Hamano
Pranit Bauva writes: > This series of patches add a configuration variable for verbose in > git-commit. > > Link to v15: > http://thread.gmane.org/gmane.comp.version-control.git/293127 > > Changes wrt v15: > * Remove the previous patch 7/7 and split the tests. Include

[PATCH v16 0/7] config commit verbose

2016-05-05 Thread Pranit Bauva
This series of patches add a configuration variable for verbose in git-commit. Link to v15: http://thread.gmane.org/gmane.comp.version-control.git/293127 Changes wrt v15: * Remove the previous patch 7/7 and split the tests. Include one in initial patch 6/7. The other one is introduced in a