Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Johannes Sixt
Am 5/6/2014 2:17, schrieb Eric Wong: Users may already store sensitive data such as imap.pass in ..git/config; making the file world-readable when git config is called to edit means their password would be compromised on a shared system. [v2: updated for section renames, as noted by Junio]

Re: [msysGit] Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Erik Faye-Lund
On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt j.s...@viscovery.net wrote: Am 5/6/2014 2:17, schrieb Eric Wong: Users may already store sensitive data such as imap.pass in ..git/config; making the file world-readable when git config is called to edit means their password would be compromised

Re: [msysGit] Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Erik Faye-Lund
On Mon, May 19, 2014 at 9:44 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt j.s...@viscovery.net wrote: Am 5/6/2014 2:17, schrieb Eric Wong: Users may already store sensitive data such as imap.pass in ..git/config; making the file world-readable

Re: [msysGit] Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Marius Storm-Olsen
On 5/19/2014 2:44 AM, Erik Faye-Lund wrote: On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt j.s...@viscovery.net wrote: I'm not proficient enough to add any ACL fiddling to fchmod that would be required by the above change, whose purpose is to be strict about permissions. Nor am I interested

Re: [msysGit] Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Thomas Braun
Am Montag, den 19.05.2014, 11:59 +0200 schrieb Erik Faye-Lund: On Mon, May 19, 2014 at 9:44 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt j.s...@viscovery.net wrote: Am 5/6/2014 2:17, schrieb Eric Wong: Users may already store sensitive data

Re: [msysGit] Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-19 Thread Erik Faye-Lund
On Mon, May 19, 2014 at 9:17 PM, Thomas Braun thomas.br...@virtuell-zuhause.de wrote: Am Montag, den 19.05.2014, 11:59 +0200 schrieb Erik Faye-Lund: On Mon, May 19, 2014 at 9:44 AM, Erik Faye-Lund kusmab...@gmail.com wrote: On Mon, May 19, 2014 at 9:13 AM, Johannes Sixt j.s...@viscovery.net

Re: [PATCH v2] config: preserve config file permissions on edits

2014-05-06 Thread Jeff King
On Tue, May 06, 2014 at 12:17:14AM +, Eric Wong wrote: Users may already store sensitive data such as imap.pass in .git/config; making the file world-readable when git config is called to edit means their password would be compromised on a shared system. Makes sense, and the patch looks

[PATCH v2] config: preserve config file permissions on edits

2014-05-05 Thread Eric Wong
Users may already store sensitive data such as imap.pass in .git/config; making the file world-readable when git config is called to edit means their password would be compromised on a shared system. [v2: updated for section renames, as noted by Junio] Signed-off-by: Eric Wong