Re: [PATCH v2] fix pushing to //server/share/dir on Windows

2016-12-15 Thread Junio C Hamano
Jeff King writes: > I don't have an opinion either way on what Windows would want, but note > that the function already _does_ convert separators to slashes. With > Johannes's original patch, you'd end up with a mix, like: > > \\server\share/dir1/file > > So this conversion is

Re: [PATCH v2] fix pushing to //server/share/dir on Windows

2016-12-15 Thread Jeff King
On Thu, Dec 15, 2016 at 08:30:52AM +0100, Torsten Bögershausen wrote: > > > Would it be reasonable to > > > write: > > > > > >/* Copy initial part of absolute path, converting separators on > > > Windows */ > > >const char *end = src + offset_1st_component(src); > > >while (src <

Re: [PATCH v2] fix pushing to //server/share/dir on Windows

2016-12-14 Thread Torsten Bögershausen
On 14/12/16 20:37, Johannes Sixt wrote: normalize_path_copy() is not prepared to keep the double-slash of a //server/share/dir kind of path, but treats it like a regular POSIX style path and transforms it to /server/share/dir. The bug manifests when 'git push //server/share/dir master' is

[PATCH v2] fix pushing to //server/share/dir on Windows

2016-12-14 Thread Johannes Sixt
normalize_path_copy() is not prepared to keep the double-slash of a //server/share/dir kind of path, but treats it like a regular POSIX style path and transforms it to /server/share/dir. The bug manifests when 'git push //server/share/dir master' is run, because tmp_objdir_add_as_alternate() uses