Re: [PATCH v2 0/5] am/rebase: share read_author_script()

2018-10-26 Thread Junio C Hamano
Phillip Wood writes: >> I spotted a weird corner case buglet, but it seems that this one is >> ready for 'next' even without fixing that "give it three times and >> we will happily continue" thing. > > Well spotted on the corner case. If you're happy to hold off on moving > it to next I can send

Re: [PATCH v2 0/5] am/rebase: share read_author_script()

2018-10-26 Thread Phillip Wood
Hi Junio On 25/10/2018 09:59, Junio C Hamano wrote: > Phillip Wood writes: > >> From: Phillip Wood >> >> Thanks to Eric for his feedback on v1. I've rerolled based on >> that. Patches 1 & 2 are new and try to address some of the concerns >> Eric raised, particularly the error handling for a

Re: [PATCH v2 0/5] am/rebase: share read_author_script()

2018-10-25 Thread Junio C Hamano
Phillip Wood writes: > From: Phillip Wood > > Thanks to Eric for his feedback on v1. I've rerolled based on > that. Patches 1 & 2 are new and try to address some of the concerns > Eric raised, particularly the error handling for a badly edited author > script. See the notes on patches 4 & 5 for

[PATCH v2 0/5] am/rebase: share read_author_script()

2018-10-18 Thread Phillip Wood
From: Phillip Wood Thanks to Eric for his feedback on v1. I've rerolled based on that. Patches 1 & 2 are new and try to address some of the concerns Eric raised, particularly the error handling for a badly edited author script. See the notes on patches 4 & 5 for the changes to those (they were