Re: [PATCH v2 00/10] object_id part 2

2015-08-03 Thread brian m. carlson
On Mon, Aug 03, 2015 at 01:33:56AM +0200, Michael Haggerty wrote: Brian, what was your experience when writing these patches? Did they tend to work as soon as they compiled without errors (i.e., not super risky) or did you often have test suite failures that you had to go back and fix (i.e.,

Re: [PATCH v2 00/10] object_id part 2

2015-08-02 Thread Michael Haggerty
On 06/14/2015 12:16 AM, brian m. carlson wrote: This is another series of conversions to struct object_id. This series converts more of the refs code and struct object to use struct object_id. It introduces an additional helper function, has_object_file, which is the equivalent of

[PATCH v2 00/10] object_id part 2

2015-06-13 Thread brian m. carlson
This is another series of conversions to struct object_id. This series converts more of the refs code and struct object to use struct object_id. It introduces an additional helper function, has_object_file, which is the equivalent of has_sha1_file. The name was chosen to be slightly more