Re: [PATCH v2 02/22] untracked cache: record .gitignore information and dir hierarchy

2014-11-17 Thread David Turner
On Sat, 2014-11-08 at 16:39 +0700, Nguyễn Thái Ngọc Duy wrote: + d = xmalloc(sizeof(*d) + len); + memset(d, 0, sizeof(*d) + len); + memcpy(d-name, name, len); calloc instead of malloc+memset? But do we really need this memset to include name if we're about to use a memcpy?

Re: [PATCH v2 02/22] untracked cache: record .gitignore information and dir hierarchy

2014-11-08 Thread brian m. carlson
On Sat, Nov 08, 2014 at 04:39:35PM +0700, Nguyễn Thái Ngọc Duy wrote: The requirement for this to work is stat info of a directory MUST change if an entry is added to or removed from that directory (and should not change often otherwise). If your OS and filesytem do not Should be filesystem