Re: [PATCH v2 1/1] pack-objects: ignore ambiguous object warnings

2018-11-07 Thread Jeff King
On Wed, Nov 07, 2018 at 05:52:05PM +0900, Junio C Hamano wrote: > Junio C Hamano writes: > > > The fix here is similar to 4c30d50 "rev-list: disable object/refname > > ambiguity check with --stdin". While the get_object_list() method > > reads the objects from stdin, turn

Re: [PATCH v2 1/1] pack-objects: ignore ambiguous object warnings

2018-11-07 Thread Junio C Hamano
Junio C Hamano writes: > The fix here is similar to 4c30d50 "rev-list: disable object/refname > ambiguity check with --stdin". While the get_object_list() method > reads the objects from stdin, turn warn_on_object_refname_ambiguity > flag (which is usually true) to false. Just for code

Re: [PATCH v2 1/1] pack-objects: ignore ambiguous object warnings

2018-11-06 Thread Junio C Hamano
Jeff King writes: > So we'd never expect to see anything except "1" in our save_warning > variable. Doing a save/restore is just about code hygiene and > maintainability. Here is what I plan to queue. Thanks, both. -- >8 -- From: Derrick Stolee Date: Tue, 6 Nov 2018 12:34:47 -0800 Subject:

Re: [PATCH v2 1/1] pack-objects: ignore ambiguous object warnings

2018-11-06 Thread Jeff King
On Tue, Nov 06, 2018 at 12:34:47PM -0800, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > A git push process runs several processes during its run, but one > includes git send-pack which calls git pack-objects and passes > the known have/wants into stdin using object ids.

[PATCH v2 1/1] pack-objects: ignore ambiguous object warnings

2018-11-06 Thread Derrick Stolee via GitGitGadget
From: Derrick Stolee A git push process runs several processes during its run, but one includes git send-pack which calls git pack-objects and passes the known have/wants into stdin using object ids. However, the default setting for core.warnAmbiguousRefs requires git pack-objects to check for