Re: [PATCH v2 1/4] lib-gpg: drop unnecessary "missing GPG" warning

2016-03-15 Thread Eric Sunshine
On Tue, Mar 15, 2016 at 3:33 PM, Johannes Schindelin wrote: > On Sun, 6 Mar 2016, Eric Sunshine wrote: >> I also sneaked in a minor style cleanup. > > Isn't this "snuck"? I'm no grammarian, but [1] says either would be fine (and we know that the Internet never lies).

Re: [PATCH v2 1/4] lib-gpg: drop unnecessary "missing GPG" warning

2016-03-15 Thread Johannes Schindelin
Hi Eric, On Sun, 6 Mar 2016, Eric Sunshine wrote: > I also sneaked in a minor style cleanup. Isn't this "snuck"? The patch is fine. Ciao, Dscho -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at

[PATCH v2 1/4] lib-gpg: drop unnecessary "missing GPG" warning

2016-03-06 Thread Eric Sunshine
When 37d3e85 (t7004: factor out gpg setup, 2011-09-07) pulled gpg detection code out of t7004-tag.sh and turned it into a standard test prerequisite, it added an unconditional "missing GPG" warning when gpg is not detected. However, this is redundant since all tests which require GPG already warn