Re: [PATCH v2 2/2] rebase: validate -C and --whitespace= parameters early

Hi Ævar, On Mon, 19 Nov 2018, Ævar Arnfjörð Bjarmason wrote: > > On Wed, Nov 14 2018, Johannes Schindelin via GitGitGadget wrote: > > > From: Johannes Schindelin > > > > It is a good idea to error out early upon seeing, say, `-Cbad`, rather > > than starting the rebase only to have the `--am`

Re: [PATCH v2 2/2] rebase: validate -C and --whitespace= parameters early

On Wed, Nov 14 2018, Johannes Schindelin via GitGitGadget wrote: > From: Johannes Schindelin > > It is a good idea to error out early upon seeing, say, `-Cbad`, rather > than starting the rebase only to have the `--am` backend complain later. > > Let's do this. > > The only options accepting

Re: [PATCH v2 2/2] rebase: validate -C and --whitespace= parameters early

Hi Phillip, On Wed, 14 Nov 2018, Phillip Wood wrote: > Thanks for doing this, I think this patch is good. Thanks! > I've not checked the first patch as I think it is the same as before > judging from the covering letter. Indeed, that's what the range-diff said. Sorry for not stating this

Re: [PATCH v2 2/2] rebase: validate -C and --whitespace= parameters early

Hi Johannes Thanks for doing this, I think this patch is good. I've not checked the first patch as I think it is the same as before judging from the covering letter. Best Wishes Phillip On 14/11/2018 16:25, Johannes Schindelin via GitGitGadget wrote: From: Johannes Schindelin It is a

[PATCH v2 2/2] rebase: validate -C and --whitespace= parameters early

From: Johannes Schindelin It is a good idea to error out early upon seeing, say, `-Cbad`, rather than starting the rebase only to have the `--am` backend complain later. Let's do this. The only options accepting parameters which we pass through to `git am` (which may, or may not, forward them