Re: [PATCH v2 2/5] Makefile: under "make dist", include the sha1collisiondetection submodule

2017-12-19 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > I started by trying to come up with something generic which would handle > future submodules, i.e.: > > git submodule foreach 'git ls-files' I am not all that interested in that. The hardcoded list I felt disturbing was not "what are the

Re: [PATCH v2 2/5] Makefile: under "make dist", include the sha1collisiondetection submodule

2017-12-08 Thread Ævar Arnfjörð Bjarmason
On Fri, Dec 08 2017, Junio C. Hamano jotted: > Ævar Arnfjörð Bjarmason writes: > >> Include the sha1collisiondetection submodule when running "make >> dist". Even though we've been shipping the sha1collisiondetection >> submodule[1] and using it by default if it's checked

Re: [PATCH v2 2/5] Makefile: under "make dist", include the sha1collisiondetection submodule

2017-12-08 Thread Junio C Hamano
Ævar Arnfjörð Bjarmason writes: > Include the sha1collisiondetection submodule when running "make > dist". Even though we've been shipping the sha1collisiondetection > submodule[1] and using it by default if it's checked out[2] anyone > downloading git as a tarball would just

[PATCH v2 2/5] Makefile: under "make dist", include the sha1collisiondetection submodule

2017-12-08 Thread Ævar Arnfjörð Bjarmason
Include the sha1collisiondetection submodule when running "make dist". Even though we've been shipping the sha1collisiondetection submodule[1] and using it by default if it's checked out[2] anyone downloading git as a tarball would just get an empty sha1collisiondetection/ directory. Doing this