On Mon, Nov 5, 2018 at 3:26 AM Anders Waldenborg wrote:
> Eric Sunshine writes:
> > Should the code tolerate a trailing colon? (Genuine question; it's
> > easy to do and would be more user-friendly.)
>
> I would make sense to allow the trailing colon, it is easy enough to
> just strip that away
Eric Sunshine writes:
> Should the code tolerate a trailing colon? (Genuine question; it's
> easy to do and would be more user-friendly.)
I would make sense to allow the trailing colon, it is easy enough to
just strip that away when reading the argument.
However I'm not sure how that would fit
Anders Waldenborg writes:
> + else if (skip_prefix(arg, "key=", )) {
> + const char *end = arg + strcspn(arg,
> ",)");
> +
> + if (opts.filter_key)
> +
On Sun, Nov 4, 2018 at 10:48 PM Junio C Hamano wrote:
> Eric Sunshine writes:
> > Does the user have to include the colon when specifying of
> > 'key='?
> > Does 'key=', do a full or partial match on trailers?
> > What happens if 'key=...' is specified multiple times?
> > Thinking further on
Eric Sunshine writes:
> Does the user have to include the colon when specifying of
> 'key='? I can see from peeking at the implementation that the
> colon must not be used, but this should be documented. Should the code
> tolerate a trailing colon? (Genuine question; it's easy to do and
> would
On Sun, Nov 4, 2018 at 10:24 AM Anders Waldenborg wrote:
> Adds a new "key=X" option to "%(trailers)" which will cause it to only
> print trailers lines which matches the specified key.
>
> Signed-off-by: Anders Waldenborg
> ---
> diff --git a/Documentation/pretty-formats.txt
>
Adds a new "key=X" option to "%(trailers)" which will cause it to only
print trailers lines which matches the specified key.
Signed-off-by: Anders Waldenborg
---
Documentation/pretty-formats.txt | 13 +
pretty.c | 15 ++-
t/t4205-log-pretty-formats.sh
7 matches
Mail list logo
