On 05.01.2014 14:42, Sebastian Schuberth wrote:
Since 2dce956 is_git_command() is a bit slow as it does file I/O in the
call to list_commands_in_dir(). Avoid the file I/O by adding an early
check for internal commands.
Considering the purpose of the series is it better to say builtin instead
On Thu, Jan 02, 2014 at 11:41:05AM -0800, Junio C Hamano wrote:
- builtin/merge.c is the same, but it is conceptually even worse.
It has the end-user supplied string and wants to see if it is a
valid strategy. If the user wants to use a custom strategy, a
single stat() to make sure
Since 2dce956 is_git_command() is a bit slow as it does file I/O in the
call to list_commands_in_dir(). Avoid the file I/O by adding an early
check for internal commands.
Considering the purpose of the series is it better to say builtin instead of
internal in the commit message?--
To
Jeff King p...@peff.net writes:
On Thu, Jan 02, 2014 at 11:41:05AM -0800, Junio C Hamano wrote:
- builtin/merge.c is the same, but it is conceptually even worse.
It has the end-user supplied string and wants to see if it is a
valid strategy. If the user wants to use a custom
Since 2dce956 is_git_command() is a bit slow as it does file I/O in the
call to list_commands_in_dir(). Avoid the file I/O by adding an early
check for internal commands.
Signed-off-by: Sebastian Schuberth sschube...@gmail.com
---
Documentation/technical/api-builtin.txt | 4 +-
builtin.h
Sebastian Schuberth sschube...@gmail.com writes:
Since 2dce956 is_git_command() is a bit slow as it does file I/O in the
call to list_commands_in_dir(). Avoid the file I/O by adding an early
check for internal commands.
I think it is a good thing to check with the list of built-in's
first,
6 matches
Mail list logo
