Re: [PATCH v2 3/8] Convert struct diff_filespec to struct object_id

On Tue, Jun 21, 2016 at 03:22:04PM -0700, Junio C Hamano wrote: > "brian m. carlson" writes: > > I was trying to make sure there is no misconversion, but some lines > that got wrapped were distracting. For example: > > > @@ -2721,7 +2722,8 @@ static int

Re: [PATCH v2 3/8] Convert struct diff_filespec to struct object_id

"brian m. carlson" writes: I was trying to make sure there is no misconversion, but some lines that got wrapped were distracting. For example: > @@ -2721,7 +2722,8 @@ static int diff_populate_gitlink(struct diff_filespec > *s, int size_only) > if

[PATCH v2 3/8] Convert struct diff_filespec to struct object_id

Convert struct diff_filespec's sha1 member to use a struct object_id called "oid" instead. The following Coccinelle semantic patch was used to implement this, followed by the transformations in object_id.cocci: @@ struct diff_filespec o; @@ - o.sha1 + o.oid.hash @@ struct diff_filespec *p; @@ -