Re: [PATCH v2 5/6] Add regression tests for stricter tag fsck'ing

2014-09-11 Thread Johannes Schindelin
Hi Junio, On Wed, 10 Sep 2014, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: + test_when_finished git update-ref -d refs/tags/wrong + git fsck --tags 2out I wonder what the command does with or without --tags option (applies to both tests added by

[PATCH v2 5/6] Add regression tests for stricter tag fsck'ing

2014-09-10 Thread Johannes Schindelin
The intent of the two new test cases is to catch general breakages in the fsck_tag() function, not so much to test it extensively, trying to strike the proper balance between thoroughness and speed. Signed-off-by: Johannes Schindelin johannes.schinde...@gmx.de --- t/t1450-fsck.sh | 39

Re: [PATCH v2 5/6] Add regression tests for stricter tag fsck'ing

2014-09-10 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: + test_when_finished git update-ref -d refs/tags/wrong + git fsck --tags 2out I wonder what the command does with or without --tags option (applies to both tests added by this patch)? Does running fsck without the option not to