Re: [PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects

Hi, On Wed, 10 Sep 2014, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: +tag=$(git hash-object -t tag -w --stdin wrong-tag) +pack1=$(echo $tag | git pack-objects tag-test) +echo remove tag object +thirtyeight=${tag#??} +rm -f

Re: [PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects

Johannes Schindelin johannes.schinde...@gmx.de writes: Hi, On Wed, 10 Sep 2014, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: +tag=$(git hash-object -t tag -w --stdin wrong-tag) +pack1=$(echo $tag | git pack-objects tag-test) +echo remove

Re: [PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects

Hi Junio, On Thu, 11 Sep 2014, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: On Wed, 10 Sep 2014, Junio C Hamano wrote: Johannes Schindelin johannes.schinde...@gmx.de writes: +tag=$(git hash-object -t tag -w --stdin wrong-tag) +

[PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects

One of the most important use cases for the strict tag object checking is when transfer.fsckobjects is set to true to catch invalid objects early on. This new regression test essentially tests the same code path by directly calling 'index-pack --strict' on a pack containing an invalid tag object.

Re: [PATCH v2 6/6] Make sure that index-pack --strict fails upon invalid tag objects

Johannes Schindelin johannes.schinde...@gmx.de writes: +test_expect_success 'index-pack --strict fails upon invalid tag' ' +sha=$(git rev-parse HEAD) +cat wrong-tag EOF +object $sha +type commit +tag guten tag + +This is an invalid tag. +EOF Missing tagger is merely a warning