Re: [PATCH v2 6/9] branch: display publish branch

2014-04-18 Thread Felipe Contreras
Jeff King wrote: On Sat, Apr 12, 2014 at 10:05:15AM -0500, Felipe Contreras wrote: As you can see; some branches are published, others are not. The ones that are not published don't have a @{publish}, and `git branch -v` doesn't show them. Why is that hard to understand? Do you

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-14 Thread Jeff King
On Sat, Apr 12, 2014 at 10:05:15AM -0500, Felipe Contreras wrote: As you can see; some branches are published, others are not. The ones that are not published don't have a @{publish}, and `git branch -v` doesn't show them. Why is that hard to understand? Do you ever push the unpublished

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-12 Thread Jeff King
On Fri, Apr 11, 2014 at 08:48:01AM -0500, Felipe Contreras wrote: I think of @{publish} as the branch the user has configured to push to; it overrides all other configurations (push.default and push refspecs). I wouldn't mind having a @{push} *in addition* to @{publish} that would have the

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-12 Thread Jeff King
On Fri, Apr 11, 2014 at 12:24:35PM -0700, Junio C Hamano wrote: But the branch.master.push setting does not do anything to git push. I am not sure I understand this. I thought that the desire behind the branch.*.push is to allow something like: ... other things in the config ...

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-12 Thread Felipe Contreras
Jeff King wrote: On Fri, Apr 11, 2014 at 08:48:01AM -0500, Felipe Contreras wrote: I think of @{publish} as the branch the user has configured to push to; it overrides all other configurations (push.default and push refspecs). I wouldn't mind having a @{push} *in addition* to @{publish}

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-12 Thread Felipe Contreras
Jeff King wrote: On Fri, Apr 11, 2014 at 12:24:35PM -0700, Junio C Hamano wrote: But the branch.master.push setting does not do anything to git push. I am not sure I understand this. I thought that the desire behind the branch.*.push is to allow something like: ... other

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-11 Thread Jeff King
On Thu, Apr 10, 2014 at 05:36:59PM -0500, Felipe Contreras wrote: I noticed that this only picks up a publish-branch if branch.*.pushremote is configured. What happened to the case when remote.pushdefault is configured? What happens when branch.*.remote is not configured for @{upstream}?

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-11 Thread Felipe Contreras
Jeff King wrote: On Thu, Apr 10, 2014 at 05:36:59PM -0500, Felipe Contreras wrote: I noticed that this only picks up a publish-branch if branch.*.pushremote is configured. What happened to the case when remote.pushdefault is configured? What happens when branch.*.remote is not

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-11 Thread Junio C Hamano
Jeff King p...@peff.net writes: For instance, it looks like your @{publish} requires config like: [branch master] pushremote = foo push = refs/heads/bar to operate. Setting pushremote affects what git push does; it will go to the foo remote. OK, and the same thing would happen if

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-11 Thread Felipe Contreras
Junio C Hamano wrote: Jeff King p...@peff.net writes: For instance, it looks like your @{publish} requires config like: [branch master] pushremote = foo push = refs/heads/bar to operate. Setting pushremote affects what git push does; it will go to the foo remote. OK,

[PATCH v2 6/9] branch: display publish branch

2014-04-10 Thread Felipe Contreras
Signed-off-by: Felipe Contreras felipe.contre...@gmail.com --- builtin/branch.c | 17 - t/t6040-tracking-info.sh | 5 +++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/builtin/branch.c b/builtin/branch.c index 17773d7..e0a8d0a 100644 ---

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-10 Thread Ramkumar Ramachandra
Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com Please write a commit message, preferably showing the new git-branch output. I noticed that this only picks up a publish-branch if branch.*.pushremote is configured. What happened to the case when

Re: [PATCH v2 6/9] branch: display publish branch

2014-04-10 Thread Felipe Contreras
Ramkumar Ramachandra wrote: Felipe Contreras wrote: Signed-off-by: Felipe Contreras felipe.contre...@gmail.com Please write a commit message, preferably showing the new git-branch output. Yeah... this has been sitting in git-fc for quite a while, I wasn't expecting to send this patch series