Re: [PATCH v3] ref-filter: fallback on alphabetical comparison

2015-10-29 Thread Karthik Nayak
On Thu, Oct 29, 2015 at 3:46 AM, Junio C Hamano wrote: > Karthik Nayak writes: > >> On Wed, Oct 28, 2015 at 1:20 AM, Junio C Hamano wrote: Hence, fallback to alphabetical comparison based on the refname whenever the other

Re: [PATCH v3] ref-filter: fallback on alphabetical comparison

2015-10-28 Thread Karthik Nayak
On Wed, Oct 28, 2015 at 1:20 AM, Junio C Hamano wrote: >> Hence, fallback to alphabetical comparison based on the refname >> whenever the other criterion is equal. Fix the test in t3203 in this >> regard. > > It is unclear what "in this regard" is. Do you mean this (I am not >

Re: [PATCH v3] ref-filter: fallback on alphabetical comparison

2015-10-28 Thread Junio C Hamano
Karthik Nayak writes: > On Wed, Oct 28, 2015 at 1:20 AM, Junio C Hamano wrote: >>> Hence, fallback to alphabetical comparison based on the refname >>> whenever the other criterion is equal. Fix the test in t3203 in this >>> regard. >> >> It is unclear

Re: [PATCH v3] ref-filter: fallback on alphabetical comparison

2015-10-27 Thread Junio C Hamano
Karthik Nayak writes: > In ref-filter.c the comparison of refs while sorting is handled by > cmp_ref_sorting() function. When sorting as per numerical values > (e.g. --sort=objectsize) there is no fallback comparison when both > refs hold the same value. This can cause

[PATCH v3] ref-filter: fallback on alphabetical comparison

2015-10-27 Thread Karthik Nayak
In ref-filter.c the comparison of refs while sorting is handled by cmp_ref_sorting() function. When sorting as per numerical values (e.g. --sort=objectsize) there is no fallback comparison when both refs hold the same value. This can cause unexpected results (i.e. the order of listing refs with