On 03/14, Brandon Williams wrote:
> On 03/14, Junio C Hamano wrote:
> > Brandon Williams writes:
> >
> > > Signed-off-by: Brandon Williams
> > > ---
> > > git-submodule.sh | 3 +--
> > > 1 file changed, 1 insertion(+), 2 deletions(-)
> > >
> > > diff --git
On 03/14, Junio C Hamano wrote:
> Brandon Williams writes:
>
> > Signed-off-by: Brandon Williams
> > ---
> > git-submodule.sh | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/git-submodule.sh b/git-submodule.sh
> > index
Stefan Beller writes:
> So to answer your original question, I think the codebase currently
> thinks by_path is handier, the name is a mere internal field in
> "struct submodule", useful for looking up its git dir.
OK, that makes sense at the conceptual level, too. When you
Stefan Beller writes:
> There we take the path as name and if a real name exists, the name
> is overwritten with the real name, i.e.
>
> name = name_for_path(path) ? name_for_path(path) : path;
>
> which IMHO is overly accepting and we should just die in case of
>
On Tue, Mar 14, 2017 at 10:46 AM, Junio C Hamano wrote:
> Brandon Williams writes:
>
>> Signed-off-by: Brandon Williams
>> ---
>> git-submodule.sh | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git
Brandon Williams writes:
> Signed-off-by: Brandon Williams
> ---
> git-submodule.sh | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/git-submodule.sh b/git-submodule.sh
> index 136e26a2c..ab233712d 100755
> --- a/git-submodule.sh
Signed-off-by: Brandon Williams
---
git-submodule.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/git-submodule.sh b/git-submodule.sh
index 136e26a2c..ab233712d 100755
--- a/git-submodule.sh
+++ b/git-submodule.sh
@@ -1010,14 +1010,13 @@ cmd_status()
7 matches
Mail list logo