Re: [PATCH v3 05/11] t0027: make hash size independent

On Fri, Aug 31, 2018 at 02:40:12PM -0400, Eric Sunshine wrote: > On Fri, Aug 31, 2018 at 2:21 PM Torsten Bögershausen wrote: > > Out of interest: why do we use a "tmp" file here? > > Would it make more sense to chain the 'tr' with 'sed' and skip the > > tmp file ? > > > > tr

Re: [PATCH v3 05/11] t0027: make hash size independent

On Fri, Aug 31, 2018 at 2:21 PM Torsten Bögershausen wrote: > > diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh > > @@ -14,11 +14,13 @@ compare_files () { > > compare_ws_file () { > > + tmp=$2.tmp > > act=$pfx.actual.$3 > > - tr '\015\000abcdef0123456789'

Re: [PATCH v3 05/11] t0027: make hash size independent

On Wed, Aug 29, 2018 at 12:56:36AM +, brian m. carlson wrote: > We transform various object IDs into all-zero object IDs for comparison. > Adjust the length as well so that this works for all hash algorithms. > > Signed-off-by: brian m. carlson > --- > t/t0027-auto-crlf.sh | 6 -- > 1

[PATCH v3 05/11] t0027: make hash size independent

We transform various object IDs into all-zero object IDs for comparison. Adjust the length as well so that this works for all hash algorithms. Signed-off-by: brian m. carlson --- t/t0027-auto-crlf.sh | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/t/t0027-auto-crlf.sh