Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-24 Thread Duy Nguyen
On Sat, Feb 24, 2018 at 1:08 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> On Fri, Feb 23, 2018 at 1:19 AM, Junio C Hamano wrote: >>> Duy Nguyen writes: >>> Now that you mention it, the only command that

Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-23 Thread Junio C Hamano
Duy Nguyen writes: > On Fri, Feb 23, 2018 at 1:19 AM, Junio C Hamano wrote: >> Duy Nguyen writes: >> >>> Now that you mention it, the only command that completes >>> --rerere-autoupdate is git-merge. Since this is "auto" I don't think

Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-23 Thread Duy Nguyen
On Fri, Feb 23, 2018 at 1:19 AM, Junio C Hamano wrote: > Duy Nguyen writes: > >> Now that you mention it, the only command that completes >> --rerere-autoupdate is git-merge. Since this is "auto" I don't think >> people want to type manually. > > Sorry, but

Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-22 Thread Junio C Hamano
Duy Nguyen writes: > Now that you mention it, the only command that completes > --rerere-autoupdate is git-merge. Since this is "auto" I don't think > people want to type manually. Sorry, but I do not quite get the connection between "since this is 'auto'" and the rest of the

Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-22 Thread Duy Nguyen
On Wed, Feb 14, 2018 at 7:53 PM, SZEDER Gábor wrote: > On Fri, Feb 9, 2018 at 12:01 PM, Nguyễn Thái Ngọc Duy > wrote: >> The new completable options are: >> >> --directory >> --exclude >> --gpg-sign >> --include >> --keep-cr >> --keep-non-patch >>

Re: [PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-14 Thread SZEDER Gábor
On Fri, Feb 9, 2018 at 12:01 PM, Nguyễn Thái Ngọc Duy wrote: > The new completable options are: > > --directory > --exclude > --gpg-sign > --include > --keep-cr > --keep-non-patch > --message-id > --no-keep-cr > --patch-format > --quiet > --reject > --resolvemsg= > >

[PATCH v3 06/42] completion: use __gitcomp_builtin in _git_am

2018-02-09 Thread Nguyễn Thái Ngọc Duy
The new completable options are: --directory --exclude --gpg-sign --include --keep-cr --keep-non-patch --message-id --no-keep-cr --patch-format --quiet --reject --resolvemsg= In-progress options like --continue will be part of --git-completion-helper then filtered out by _git_am() unless the