Re: [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper

2018-03-05 Thread Brandon Williams
On 03/02, Jeff King wrote: > On Fri, Feb 23, 2018 at 01:22:31PM -0800, Brandon Williams wrote: > > > On 02/22, Stefan Beller wrote: > > > On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams > > > wrote: > > > > > > > +static void pack_line(const char *line) > > > > +{ > > > > +

Re: [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper

2018-03-02 Thread Jeff King
On Fri, Feb 23, 2018 at 01:22:31PM -0800, Brandon Williams wrote: > On 02/22, Stefan Beller wrote: > > On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams wrote: > > > > > +static void pack_line(const char *line) > > > +{ > > > + if (!strcmp(line, "") || !strcmp(line,

Re: [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper

2018-02-23 Thread Brandon Williams
On 02/22, Stefan Beller wrote: > On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams wrote: > > > +static void pack_line(const char *line) > > +{ > > + if (!strcmp(line, "") || !strcmp(line, "\n")) > > From our in-office discussion: > v1/v0 packs pktlines twice in

Re: [PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper

2018-02-22 Thread Stefan Beller
On Tue, Feb 6, 2018 at 5:12 PM, Brandon Williams wrote: > +static void pack_line(const char *line) > +{ > + if (!strcmp(line, "") || !strcmp(line, "\n")) >From our in-office discussion: v1/v0 packs pktlines twice in http, which is not possible to construct using

[PATCH v3 11/35] test-pkt-line: introduce a packet-line test helper

2018-02-06 Thread Brandon Williams
Introduce a packet-line test helper which can either pack or unpack an input stream into packet-lines and writes out the result to stdout. Signed-off-by: Brandon Williams --- Makefile | 1 + t/helper/test-pkt-line.c | 64