Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

2018-02-15 Thread Оля Тележная
2018-02-15 8:51 GMT+03:00 Jeff King : > On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > >> Move logic related to skip_object_info into ref-filter, >> so that cat-file does not use that field at all. > > I think this is going the wrong way. ref-filter should always

Re: [PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

2018-02-14 Thread Jeff King
On Mon, Feb 12, 2018 at 08:08:54AM +, Olga Telezhnaya wrote: > Move logic related to skip_object_info into ref-filter, > so that cat-file does not use that field at all. I think this is going the wrong way. ref-filter should always do as little work as possible to fulfill the request. So it

[PATCH v3 15/23] cat-file: move skip_object_info into ref-filter

2018-02-12 Thread Olga Telezhnaya
Move logic related to skip_object_info into ref-filter, so that cat-file does not use that field at all. Signed-off-by: Olga Telezhnaia Mentored-by: Christian Couder Mentored by: Jeff King --- builtin/cat-file.c | 7 +--