Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-03-26 Thread Junio C Hamano
Duy Nguyen pclo...@gmail.com writes: On Tue, Mar 25, 2014 at 08:52:13PM +0700, Duy Nguyen wrote: On Mon, Mar 24, 2014 at 9:52 PM, Torsten Bögershausen tbo...@web.de wrote: Did I report that t1501 fails when there is a softlink in $PWD ? /home/tb/projects is a softlink to /disc5/projects/

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-03-25 Thread Duy Nguyen
On Tue, Mar 25, 2014 at 08:52:13PM +0700, Duy Nguyen wrote: On Mon, Mar 24, 2014 at 9:52 PM, Torsten Bögershausen tbo...@web.de wrote: Did I report that t1501 fails when there is a softlink in $PWD ? /home/tb/projects is a softlink to /disc5/projects/ Yes you did and I forgot. I have

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-03-25 Thread Duy Nguyen
On Mon, Mar 24, 2014 at 9:52 PM, Torsten Bögershausen tbo...@web.de wrote: Did I report that t1501 fails when there is a softlink in $PWD ? /home/tb/projects is a softlink to /disc5/projects/ Yes you did and I forgot. I have fixed it, running test suite and will send the reroll soon. -- Duy

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-03-24 Thread Torsten Bögershausen
On 02/18/2014 02:40 PM, Nguyễn Thái Ngọc Duy wrote: The repo setup procedure is updated to detect $GIT_DIR/commondir and set $GIT_COMMON_DIR properly. The core.worktree is ignored when $GIT_DIR/commondir presents. This is because commondir repos are intended for separate/linked checkouts and

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-02-27 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: The repo setup procedure is updated to detect $GIT_DIR/commondir and set $GIT_COMMON_DIR properly. The core.worktree is ignored when $GIT_DIR/commondir presents. This is because commondir repos are intended for separate/linked checkouts and

Re: [PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-02-19 Thread Junio C Hamano
Nguyễn Thái Ngọc Duy pclo...@gmail.com writes: (Only nitpicks during this round of review). diff --git a/t/t1501-worktree.sh b/t/t1501-worktree.sh index 8f36aa9..d8bdaf4 100755 --- a/t/t1501-worktree.sh +++ b/t/t1501-worktree.sh @@ -346,4 +346,80 @@ test_expect_success 'relative

[PATCH v3 18/25] setup.c: support multi-checkout repo setup

2014-02-18 Thread Nguyễn Thái Ngọc Duy
The repo setup procedure is updated to detect $GIT_DIR/commondir and set $GIT_COMMON_DIR properly. The core.worktree is ignored when $GIT_DIR/commondir presents. This is because commondir repos are intended for separate/linked checkouts and pointing them back to a fixed core.worktree just does