Re: [PATCH v3 2/8] upload-pack: implement ref-in-want

2018-06-25 Thread Brandon Williams
On 06/25, Jonathan Tan wrote: > > +static int parse_want_ref(const char *line, struct string_list > > *wanted_refs) > > +{ > > + const char *arg; > > + if (skip_prefix(line, "want-ref ", )) { > > + struct object_id oid; > > + struct string_list_item *item; > > +

Re: [PATCH v3 2/8] upload-pack: implement ref-in-want

2018-06-25 Thread Jonathan Tan
> +static int parse_want_ref(const char *line, struct string_list *wanted_refs) > +{ > + const char *arg; > + if (skip_prefix(line, "want-ref ", )) { > + struct object_id oid; > + struct string_list_item *item; > + struct object *o; > + > +

Re: [PATCH v3 2/8] upload-pack: implement ref-in-want

2018-06-25 Thread Jonathan Tan
> +wanted-refs section > + * This section is only included if the client has requested a > + ref using a 'want-ref' line and if a packfile section is also > + included in the response. > + > + * Always begins with the section header "wanted-refs" Add a period at the end to

[PATCH v3 2/8] upload-pack: implement ref-in-want

2018-06-20 Thread Brandon Williams
Currently, while performing packfile negotiation, clients are only allowed to specify their desired objects using object ids. This causes a vulnerability to failure when an object turns non-existent during negotiation, which may happen if, for example, the desired repository is provided by