Re: [PATCH v3 3/5] ref-filter: change parsing function error handling

2018-03-19 Thread Junio C Hamano
Olga Telezhnaya writes: > Continue removing any printing from ref-filter formatting logic, > so that it could be more general. > > Change the signature of parse_ref_filter_atom() by adding > strbuf parameter for error message. > Return value means the same except

[PATCH v3 3/5] ref-filter: change parsing function error handling

2018-03-19 Thread Olga Telezhnaya
Continue removing any printing from ref-filter formatting logic, so that it could be more general. Change the signature of parse_ref_filter_atom() by adding strbuf parameter for error message. Return value means the same except negative values: they indicate errors (previous version could return