Re: [PATCH v3 6/6] Make sure that index-pack --strict checks tag objects

2014-09-12 Thread Johannes Schindelin
Hi Junio, On Thu, 11 Sep 2014, Junio C Hamano wrote: Junio C Hamano gits...@pobox.com writes: When our toolset has become too tight without leaving enough escape hatch to hinder further development, it is very sensible to at least think about adding a new --for-debug option to

[PATCH v3 6/6] Make sure that index-pack --strict checks tag objects

2014-09-11 Thread Johannes Schindelin
One of the most important use cases for the strict tag object checking is when transfer.fsckobjects is set to true to catch invalid objects early on. This new regression test essentially tests the same code path by directly calling 'index-pack --strict' on a pack containing an tag object without a

Re: [PATCH v3 6/6] Make sure that index-pack --strict checks tag objects

2014-09-11 Thread Junio C Hamano
Johannes Schindelin johannes.schinde...@gmx.de writes: One of the most important use cases for the strict tag object checking is when transfer.fsckobjects is set to true to catch invalid objects early on. This new regression test essentially tests the same code path by directly calling

Re: [PATCH v3 6/6] Make sure that index-pack --strict checks tag objects

2014-09-11 Thread Junio C Hamano
Junio C Hamano gits...@pobox.com writes: When our toolset has become too tight without leaving enough escape hatch to hinder further development, it is very sensible to at least think about adding a new --for-debug option to hash-object and pack-objects that allows us to deliberately create