Re: [PATCH v4 00/13] Serialized Git Commit Graph

Derrick Stolee writes: > On 4/2/2018 10:46 AM, Jakub Narebski wrote: >> Derrick Stolee writes: > [...] >> I see the FELINE-index as a stronger form of generation numbers (called >> also level of the vertex / node), in that it allows to negative-cut even >>

Re: [PATCH v4 00/13] Serialized Git Commit Graph

> Currently, the format includes 8 bytes to share between the generation > number and commit date. Due to alignment concerns, we will want to keep this > as 8 bytes or truncate it to 4-bytes. Either we would be wasting at least 3 > bytes or truncating dates too much (presenting the 2038 problem

Re: [PATCH v4 00/13] Serialized Git Commit Graph

On 4/2/2018 1:35 PM, Stefan Beller wrote: On Mon, Apr 2, 2018 at 8:02 AM, Derrick Stolee wrote: I would be happy to review any effort to extend the commit-graph format to include such indexes, as long as the performance benefits outweigh the complexity to create them. [2]

Re: [PATCH v4 00/13] Serialized Git Commit Graph

On Mon, Apr 2, 2018 at 8:02 AM, Derrick Stolee wrote: >>> >>> I would be happy to review any effort to extend the commit-graph >>> format to include such indexes, as long as the performance benefits >>> outweigh the complexity to create them. >>> >>> [2] >>>

Re: [PATCH v4 00/13] Serialized Git Commit Graph

On 4/2/2018 10:46 AM, Jakub Narebski wrote: Derrick Stolee writes: [...] At one point, I was investigating these reachability indexes (I read "SCARAB: Scaling Reachability Computation on Large Graphs" by Jihn, Ruan, Dey, and Xu [2]) but find the question that these indexes

Re: [PATCH v4 00/13] Serialized Git Commit Graph

Derrick Stolee writes: > On 3/30/2018 7:10 AM, Jakub Narebski wrote: >> I hope that I am addressing the most recent version of this series. > > Hi Jakub. Thanks for the interest in this patch series. > > The most-recent version is v6 [1], but I will re-roll to v7 soon > (after

Re: [PATCH v4 00/13] Serialized Git Commit Graph

On 3/30/2018 7:10 AM, Jakub Narebski wrote: I hope that I am addressing the most recent version of this series. Hi Jakub. Thanks for the interest in this patch series. The most-recent version is v6 [1], but I will re-roll to v7 soon (after v2.17.0 is marked). [1]

Re: [PATCH v4 00/13] Serialized Git Commit Graph

I hope that I am addressing the most recent version of this series. Derrick Stolee writes: > As promised [1], this patch contains a way to serialize the commit graph. > The current implementation defines a new file format to store the graph > structure (parent relationships)

[PATCH v4 00/13] Serialized Git Commit Graph

Thanks for all of the feedback. I've learned a lot working on this patch. As discussed [0], this version changes several fundamental structures and operations, including: * Graph files are stored in .git/objects/info * The "graph-head" file is now called "graph-latest" to avoid confusion with