Re: [PATCH v4 01/13] commit-graph: add format document

Derrick Stolee writes: > On 3/30/2018 9:25 AM, Jakub Narebski wrote: >> Derrick Stolee writes: >> >>> +== graph-*.graph files have the following format: >> What is this '*' here? > > No longer necessary. It used to be a placeholder for a hash value, but > now

Re: [PATCH v4 01/13] commit-graph: add format document

On 3/30/2018 9:25 AM, Jakub Narebski wrote: Derrick Stolee writes: +== graph-*.graph files have the following format: What is this '*' here? No longer necessary. It used to be a placeholder for a hash value, but now the graph is stored in objects/info/commit-graph.

Re: [PATCH v4 01/13] commit-graph: add format document

Derrick Stolee writes: > +== graph-*.graph files have the following format: What is this '*' here? [...] > + The remaining data in the body is described one chunk at a time, and > + these chunks may be given in any order. Chunks are required unless > + otherwise specified.

Re: [PATCH v4 01/13] commit-graph: add format document

>> >> [ so in small repos, where there are fewer than 256 objects, >> F[i] == F[i+1], for all i'th where there is no object starting with i >> byte] > > > Correct. I'm not sure this additional information is valuable for the > document, though. It is not, I was just making sure I'd understand

Re: [PATCH v4 01/13] commit-graph: add format document

On 2/21/2018 2:23 PM, Stefan Beller wrote: On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: +In order to allow extensions that add extra data to the graph, we organize +the body into "chunks" and provide a binary lookup table at the beginning +of the body. The header

Re: [PATCH v4 01/13] commit-graph: add format document

On Mon, Feb 19, 2018 at 10:53 AM, Derrick Stolee wrote: > Add document specifying the binary format for commit graphs. This > format allows for: > > * New versions. > * New hash functions and hash lengths. > * Optional extensions. > > Basic header information is followed by a

Re: [PATCH v4 01/13] commit-graph: add format document

Derrick Stolee writes: > Documentation/technical/commit-graph-format.txt | 90 > + > 1 file changed, 90 insertions(+) > create mode 100644 Documentation/technical/commit-graph-format.txt Hopefully just a few remaining nits. Overall I find this

[PATCH v4 01/13] commit-graph: add format document

Add document specifying the binary format for commit graphs. This format allows for: * New versions. * New hash functions and hash lengths. * Optional extensions. Basic header information is followed by a binary table of contents into "chunks" that include: * An ordered list of commit object