Re: [PATCH v4 3/3] connect: advertized capability is not a ref

2016-09-09 Thread Junio C Hamano
Jonathan Nieder writes: > Jonathan Tan wrote: > >> --- a/connect.c >> +++ b/connect.c >> @@ -172,8 +173,24 @@ struct ref **get_remote_heads(int in, char *src_buf, >> size_t src_len, >> continue; >> } >> >> +if (!strcmp(name,

Re: [PATCH v4 3/3] connect: advertized capability is not a ref

2016-09-09 Thread Junio C Hamano
Jonathan Tan writes: > Git advertises the same capabilities^{} ref in its ref advertisement for push > but since it never did so for fetch, the client didn't need to handle this > case. Handle it. > > In this aspect, JGit is compliant with the specification in

Re: [PATCH v4 3/3] connect: advertized capability is not a ref

2016-09-09 Thread Jonathan Nieder
Jonathan Tan wrote: > --- a/connect.c > +++ b/connect.c > @@ -172,8 +173,24 @@ struct ref **get_remote_heads(int in, char *src_buf, > size_t src_len, > continue; > } > > + if (!strcmp(name, "capabilities^{}")) { > + if

[PATCH v4 3/3] connect: advertized capability is not a ref

2016-09-09 Thread Jonathan Tan
When cloning an empty repository served by standard git, "git clone" produces the following reassuring message: $ git clone git://localhost/tmp/empty Cloning into 'empty'... warning: You appear to have cloned an empty repository. Checking connectivity... done.