Re: [PATCH v5 0/4] Improve abbreviation disambiguation

2017-10-12 Thread Jeff King
On Thu, Oct 12, 2017 at 09:21:15PM +0900, Junio C Hamano wrote: > Derrick Stolee writes: > > > On 10/12/2017 8:02 AM, Derrick Stolee wrote: > >> Changes since previous version: > >> > >> * Make 'pos' unsigned in get_hex_char_from_oid() > >> > >> * Check response from

Re: [PATCH v5 0/4] Improve abbreviation disambiguation

2017-10-12 Thread Junio C Hamano
Derrick Stolee writes: > On 10/12/2017 8:02 AM, Derrick Stolee wrote: >> Changes since previous version: >> >> * Make 'pos' unsigned in get_hex_char_from_oid() >> >> * Check response from open_pack_index() >> >> * Small typos in commit messages >> >> Thanks, >> Stolee >> > I

Re: [PATCH v5 0/4] Improve abbreviation disambiguation

2017-10-12 Thread Derrick Stolee
On 10/12/2017 8:02 AM, Derrick Stolee wrote: Changes since previous version: * Make 'pos' unsigned in get_hex_char_from_oid() * Check response from open_pack_index() * Small typos in commit messages Thanks, Stolee I forgot to mention that I rebased on master this morning to be sure this

[PATCH v5 0/4] Improve abbreviation disambiguation

2017-10-12 Thread Derrick Stolee
Changes since previous version: * Make 'pos' unsigned in get_hex_char_from_oid() * Check response from open_pack_index() * Small typos in commit messages Thanks, Stolee --- When displaying object ids, we frequently want to see an abbreviation for easier typing. That abbreviation must be