Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Eric Sunshine
On Tue, Nov 17, 2015 at 4:34 AM, Luke Diamand wrote: >>> While implementing it I thought more about it. P4D is only >>> supported on platforms that support the date function. That means >>> these tests will only run on platforms that support the date >>> function. Consequently I

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Luke Diamand
>> >> Which other platforms are we talking about here? >> >> https://www.perforce.com/downloads/helix >> >> From there, you can get Solaris10, HP-UX, AIX and various flavours of BSD. >> Solaris supports "date +%s". > > The question about "date +%s" portability arose with a suggestion to > employ

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Lars Schneider
On 16 Nov 2015, at 22:14, Eric Sunshine wrote: > On Sun, Nov 15, 2015 at 8:08 AM, wrote: >> From: Lars Schneider >> >> In rare cases kill/cleanup operations in tests fail. Retry these >> operations with a timeout

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Luke Diamand
While implementing it I thought more about it. P4D is only supported on platforms that support the date function. That means these tests will only run on platforms that support the date function. Consequently I wondered if this would justify the slightly more complicated code. However, if you

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Lars Schneider
On 16 Nov 2015, at 09:36, Luke Diamand wrote: > On 15/11/15 13:08, larsxschnei...@gmail.com wrote: >> From: Lars Schneider >> >> In rare cases kill/cleanup operations in tests fail. Retry these >> operations with a timeout to make the test less

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Luke Diamand
On 17/11/15 08:22, Lars Schneider wrote: On 16 Nov 2015, at 09:36, Luke Diamand wrote: On 15/11/15 13:08, larsxschnei...@gmail.com wrote: From: Lars Schneider In rare cases kill/cleanup operations in tests fail. Retry these operations with a

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-17 Thread Eric Sunshine
On Tue, Nov 17, 2015 at 3:28 AM, Lars Schneider wrote: > On 16 Nov 2015, at 22:14, Eric Sunshine wrote: >> On Sun, Nov 15, 2015 at 8:08 AM, wrote: >>> From: Lars Schneider >>> >>> In rare

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-16 Thread Eric Sunshine
On Sun, Nov 15, 2015 at 8:08 AM, wrote: > From: Lars Schneider > > In rare cases kill/cleanup operations in tests fail. Retry these > operations with a timeout to make the test less flaky. > > Signed-off-by: Lars Schneider

Re: [PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-16 Thread Luke Diamand
On 15/11/15 13:08, larsxschnei...@gmail.com wrote: From: Lars Schneider In rare cases kill/cleanup operations in tests fail. Retry these operations with a timeout to make the test less flaky. Should there be a sleep in that retry_until_success loop so that it

[PATCH v5 3/6] git-p4: retry kill/cleanup operations in tests with timeout

2015-11-15 Thread larsxschneider
From: Lars Schneider In rare cases kill/cleanup operations in tests fail. Retry these operations with a timeout to make the test less flaky. Signed-off-by: Lars Schneider --- t/lib-git-p4.sh | 31 +++ 1 file